Skip to content

add non binary gender in enum#389

Merged
felipao-mx merged 1 commit intomainfrom
feat/add-non-binary-gender
Oct 6, 2025
Merged

add non binary gender in enum#389
felipao-mx merged 1 commit intomainfrom
feat/add-non-binary-gender

Conversation

@rcabrera-py
Copy link
Copy Markdown
Contributor

@rcabrera-py rcabrera-py commented Oct 6, 2025

Summary by CodeRabbit

  • New Features

    • Added support for a new gender option: non_binary. Validation and serialization now accept and return this value wherever gender is used, improving inclusivity and flexibility. Backwards compatible; existing integrations and stored data remain unchanged. No configuration required.
  • Chores

    • Package version bumped to 2.1.18.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

  • Added a new enum member non_binary to Gender in cuenca_validations/types/enums.py.
  • Updated __version__ in cuenca_validations/version.py from 2.1.17 to 2.1.18.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change of adding a non-binary gender value to the enum without extraneous detail, making it clear to reviewers and maintainers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-non-binary-gender

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14807f4 and 2016b51.

📒 Files selected for processing (2)
  • cuenca_validations/types/enums.py (1 hunks)
  • cuenca_validations/version.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • cuenca_validations/types/enums.py
  • cuenca_validations/version.py

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e148e74) to head (2016b51).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1394      1395    +1     
=========================================
+ Hits          1394      1395    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca_validations/types/enums.py 100.00% <100.00%> (ø)
cuenca_validations/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e148e74...2016b51. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rcabrera-py rcabrera-py force-pushed the feat/add-non-binary-gender branch from 14807f4 to 2016b51 Compare October 6, 2025 17:35
@felipao-mx felipao-mx merged commit fe78144 into main Oct 6, 2025
29 checks passed
@felipao-mx felipao-mx deleted the feat/add-non-binary-gender branch October 6, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants