Hugo: add searchTerm option to search shortcode#489
Hugo: add searchTerm option to search shortcode#489JuanUsMedia wants to merge 1 commit intomasterfrom
Conversation
✅ Deploy Preview for cue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
3eb1865 to
a8713db
Compare
JorindeUsMedia
left a comment
JorindeUsMedia
left a comment
There was a problem hiding this comment.
Overall looks good! Just 1 testcase where it doesnt work: searchTerm set but not tags pre-selected
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
a8713db to
2441f96
Compare
There was a problem hiding this comment.
The only edge case which I found while testing: Remove all preselected terms & tags: the search will reset to the preselected filters & term. There is no way to empty it. But I don't know how to fix that because on page load there is also no search term and than the preselected term kicks in: that's what we want. There's no way to know now if the user emptied it or if we started fresh. It's also preselected for a reason :)
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
2441f96 to
64a4e58
Compare
jpluscplusm
left a comment
jpluscplusm
left a comment
There was a problem hiding this comment.
LGTM! Please just fix the DCO and my last comment, and I'll submit this :-)
* Add searchTerm to example page * Pass searchTerm from search shortcode, through search partial, to filter partial * Set initial searchItem with search filter To test: * Navigate to /examples/shortcodes/search and verify that the search results are accurate. Fixes cue-lang/cue#3566 Signed-off-by: juanstelling <juan.stelling@usmedia.nl>
JuanUsMedia
force-pushed
the
usmedia-n/3566
branch
from
64a4e58 to
9bc6197
Compare
jpluscplusm
left a comment
jpluscplusm
left a comment
There was a problem hiding this comment.
LGTM - I'll import into Gerrit after we've resolved the unrelated CI test failures.
3 participants
To test:
Fixes cue-lang/cue#3566