Normalize memory allocation in C code to use ALLOC/REALLOC/FREE macros #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert direct malloc() calls to ALLOC() macro in cstringstream.c - Convert direct realloc() calls to REALLOC() macro in cstringstream.c - Convert direct free() calls to FREE() macro in cstringstream.c - Add util.h include to cstringstream.c for macro availability - Ensures consistent memory management and error handling across codebase - All existing tests continue to pass Changes: - 3 malloc() → ALLOC() conversions - 1 realloc() → REALLOC() conversion - 2 free() → FREE() conversions This change standardizes memory allocation to use the centralized memory management macros, providing consistent error handling through MMalloc/MMrealloc when USE_MM is not defined, and automatic pointer zeroing with the FREE() macro. Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Pull Request Test Coverage Report for Build 19172131886Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code base uses an ALLOC/REALLOC/FREE macros almost everywhere, but it appears as if cstringstream.c was missed. This change updates this file to match the rest of the cod base.
Changes:
This change standardizes memory allocation to use the centralized memory management macros, providing consistent error handling through MMalloc/MMrealloc when USE_MM is not defined, and automatic pointer zeroing with the FREE() macro.