Skip to content

Conversation

@davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 21, 2025

🤔 What's changed?

Now that the query library is more fleshed out, we can reimplement some of the filtering and statistics logic with it. This simplifies things quite a bit.

While we're here, there's also an overdue rework of testing:

  • As the compatibility kit is now so much more comprehensive, we can use existing samples for most tests, and remove the tests with test data copied from Gherkin which had become superfluous
  • The custom test-utils file wasn't justifying existence any more - we're now importing testing-library stuff directly in tests and wrapping them with providers where needed
  • No more dependencies on fake-cucumber (deprecated) or gherkin-streams

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@netlify
Copy link

netlify bot commented Dec 21, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 3fe7e7b
🔍 Latest deploy log https://app.netlify.com/projects/cucumber-react-preview/deploys/694976a213d9f400080546b9
😎 Deploy Preview https://deploy-preview-420--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@davidjgoss davidjgoss force-pushed the filter-and-search-rewrite branch from c5dd404 to 4b194a7 Compare December 22, 2025 16:23
@davidjgoss davidjgoss force-pushed the filter-and-search-rewrite branch from a01712a to 3fe7e7b Compare December 22, 2025 16:49
@davidjgoss davidjgoss marked this pull request as ready for review December 22, 2025 17:15
@davidjgoss davidjgoss merged commit 5788c74 into main Dec 22, 2025
6 checks passed
@davidjgoss davidjgoss deleted the filter-and-search-rewrite branch December 22, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant