Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds support for joins when both sides are grouped to be used with SQL push down. Related test is included.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested review from a team as code owners December 10, 2025 02:38
@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 92.03822% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.03%. Comparing base (6271520) to head (3d81b3d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 83.84% 21 Missing ⚠️
.../cubesql/src/compile/rewrite/rules/wrapper/join.rs 97.27% 3 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 97.95% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10234       +/-   ##
===========================================
+ Coverage   55.09%   78.03%   +22.93%     
===========================================
  Files         221      468      +247     
  Lines       17109    91663    +74554     
  Branches     3498     3498               
===========================================
+ Hits         9427    71530    +62103     
- Misses       7184    19635    +12451     
  Partials      498      498               
Flag Coverage Δ
cube-backend 55.09% <ø> (ø)
cubesql 83.29% <92.03%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants