-
Notifications
You must be signed in to change notification settings - Fork 0
Integration/charles release #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xhether
wants to merge
10
commits into
main
Choose a base branch
from
integration/charles-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPeterss
approved these changes
Nov 21, 2025
Contributor
MrPeterss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work charles! Just a couple of comments
Resell/Resources/Assets.xcassets/read-notification.imageset/mage_message-round 3.png
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Release ready
Changes Made
Piggybacking off of my last PR. Ready for MVP release. Fixed styling bugs for light/dark mode. Fixed many performance bugs with unnecessary reloads on homepage and profile pages. Fixed login issue when users login to multiple accounts on one device.
Identical to last PR and fixed any lasting bugs... LMK if you want me to add screenshots/videos/more detail.
Some of this code is a little vibe-codey and may not be the greatest solution to some of our problems (like I'm a bit sus about the time based-caching), but overall gets the job done and makes the app significantly more usable than b4.
I also think its best to squash merge this PR as its so naturally messy due to its size. Last time I ran into a lot of issues with the commit histories, but I may be wrong...