driver.py: aarch64: constants only need 4 KiB alignment#87
Merged
Conversation
The "page-alignment" required for `adrp` is fixed from the aarch64 ISA at 4 KiB and doesn't actually represent the machine's physical page size.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 168 168
Lines 40284 40284
=======================================
Hits 40009 40009
Misses 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #87 will degrade performances by 28.09%Comparing Summary
Benchmarks breakdown
|
ctz
approved these changes
May 17, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured I'd pull this change out into a separate diff.
As discussed here: #74 (comment)
The "page-alignment" required for
adrpis fixed from the aarch64 ISA at 4 KiB and doesn't actually represent the machine's physical page size.With this change, we can save a bit of .data by reducing alignment for constants on aarch64 from 16 KiB -> 4 KiB.