Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 99.64% 99.71% +0.06%
==========================================
Files 170 184 +14
Lines 39559 50730 +11171
==========================================
+ Hits 39419 50585 +11166
- Misses 140 145 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Performance Changes
Comparing 
|
phlip9
reviewed
Nov 25, 2025
Contributor
phlip9
left a comment
phlip9
left a comment
There was a problem hiding this comment.
Thanks a ton for bringing this over the finish line! And I apologize for the mess of WIP commits 😅
Figured I would leave some comments as a potential user of both rustls-graviola and graviola::signing::eddsa
ctz
force-pushed
the
jbp-ed25519
branch
3 times, most recently
from
acc0093 to
e320838
Compare
Owner
Author
|
Thanks for the comments, I have addressed most of these. |
ctz
force-pushed
the
jbp-ed25519
branch
2 times, most recently
from
035bd25 to
283dcde
Compare
Ex: `#define foo() bl edwards25519_decode_alt_mul_p25519`
Before this change, the generated rust macro didn't wire up the local label
reference properly:
```rust
macro_rules! foo { () => { Q!(
"bl " Label!("edwards25519_decode_alt_mul_p25519", 0, Before)
)} }
```
After this change:
```rust
macro_rules! foo { () => { Q!(
"bl " Label!("edwards25519_decode_alt_mul_p25519", 4, After)
)} }
```
To support this, we now track which macros reference labels. We then track
which blocks call these macros. As long as all macro callsites are uniformly
before or after the labels they reference, we can safely replace the local label
id and search direction in the original macro definition.
It was challenging to track macro callsites in the main `RustFormatter` and also
difficult to "pre-locate" callsites while dealing with hoisting, so the actual
macro fixing happens on the generated Rust code from the `RustFormatter` pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work-in-progress Ed25519 support. Much of the work is thanks to @phlip9 in #74
Draft while I do these items:
fixes #74