Merged
Conversation
The fix_* functions are no longer needed.
There was a problem hiding this comment.
Pull Request Overview
This pull request removes four fix_* functions that were previously used to handle database column type differences between MySQL/MariaDB and SQLite3 for testing purposes. The functions are no longer needed as indicated in the PR description.
- Removes four
fix_data_in_*functions from the R/transform.R file - Removes corresponding documentation files from the man/ directory
- Updates the NAMESPACE file to remove the exported function declarations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| R/transform.R | Removes the implementation of four fix_data_in_* functions that handled database type conversions |
| NAMESPACE | Removes export declarations for the deleted functions |
| man/fix_data_in_redcap_user_information.Rd | Removes roxygen2-generated documentation for the deleted function |
| man/fix_data_in_redcap_projects.Rd | Removes roxygen2-generated documentation for the deleted function |
| man/fix_data_in_invoice_line_item_communication.Rd | Removes roxygen2-generated documentation for the deleted function |
| man/fix_data_in_invoice_line_item.Rd | Removes roxygen2-generated documentation for the deleted function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix_* functions are no longer needed.