Skip to content

Remove fix_* functions#284

Merged
pbchase merged 1 commit intoctsit:developfrom
pbchase:remove_fix_functions
Sep 30, 2025
Merged

Remove fix_* functions#284
pbchase merged 1 commit intoctsit:developfrom
pbchase:remove_fix_functions

Conversation

@pbchase
Copy link
Contributor

@pbchase pbchase commented Sep 30, 2025

The fix_* functions are no longer needed.

The fix_* functions are no longer needed.
@pbchase pbchase requested a review from Copilot September 30, 2025 13:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes four fix_* functions that were previously used to handle database column type differences between MySQL/MariaDB and SQLite3 for testing purposes. The functions are no longer needed as indicated in the PR description.

  • Removes four fix_data_in_* functions from the R/transform.R file
  • Removes corresponding documentation files from the man/ directory
  • Updates the NAMESPACE file to remove the exported function declarations

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
R/transform.R Removes the implementation of four fix_data_in_* functions that handled database type conversions
NAMESPACE Removes export declarations for the deleted functions
man/fix_data_in_redcap_user_information.Rd Removes roxygen2-generated documentation for the deleted function
man/fix_data_in_redcap_projects.Rd Removes roxygen2-generated documentation for the deleted function
man/fix_data_in_invoice_line_item_communication.Rd Removes roxygen2-generated documentation for the deleted function
man/fix_data_in_invoice_line_item.Rd Removes roxygen2-generated documentation for the deleted function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pbchase pbchase merged commit 0a02ef1 into ctsit:develop Sep 30, 2025
1 check passed
@pbchase pbchase deleted the remove_fix_functions branch September 30, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants