Skip to content

fix: do not scale down when execs are running #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctrox merged 1 commit into from
Mar 10, 2026
+11 −6
Merged

fix: do not scale down when execs are running #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions shim/task/service_zeropod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,18 @@ func (w *wrapper) Delete(ctx context.Context, r *taskAPI.DeleteRequest) (*taskAP
}
log.G(ctx).Infof("delete called in zeropod: %s", zeropodContainer.ID())

if len(r.ExecID) != 0 {
// on delete of an exec container we want to schedule scaling down again.
if err := zeropodContainer.ScheduleScaleDown(); err != nil {
return nil, err
}
} else {
if r.ExecID == "" {
w.deleteZeropodContainer(r.ID)
} else {
w.lifecycleMu.Lock()
// on delete of an exec container we want to schedule scaling down again
// but only if there are no other running execs.
if w.runningExecs[zeropodContainer.Container] == 0 {
if err := zeropodContainer.ScheduleScaleDown(); err != nil {
return nil, err
}
}
w.lifecycleMu.Unlock()
}
return w.service.Delete(ctx, r)
}
Expand Down