Skip to content

Conversation

@droberts-ctrlo
Copy link
Contributor

@droberts-ctrlo droberts-ctrlo commented Sep 26, 2025

Create default report for download PDF link using GADS::PDFGenerator custom class

@droberts-ctrlo droberts-ctrlo changed the title Completed default report setup Completed default report setup (D 800) Dec 17, 2025
@droberts-ctrlo droberts-ctrlo changed the title Completed default report setup (D 800) Complete default report setup (D 800) Dec 17, 2025
@abeverley
Copy link
Contributor

Thanks, looking good. Final few minor comments:

  • Topics don't seem to necessarily be the correct order (I'm not sure why at this stage, just the test I have run)
  • Can we line-up fat commas please?
  • I think the PDF heading should be the same as it used to be ("Record 123") rather than the filename "Record-123.pdf"

@droberts-ctrlo
Copy link
Contributor Author

Fixed as per review - topics appear in the order they are in the layout view.

@abeverley
Copy link
Contributor

Thanks Dave, but I think the heading change is missing now? All good once that is updated.

@abeverley abeverley merged commit 61dda06 into ctrlo:dev Jan 26, 2026
5 of 6 checks passed
@droberts-ctrlo droberts-ctrlo deleted the default-reports branch January 26, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants