Ability to cancel future events on return false / Avoid generating keyframe selectors with same id #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary use is to listen to first match on comma separated selectors.
Fixes bug with initializing multiple selector-listeners at the same time.
riyazshaikh
changed the title
Added onSelector() to stop after single selector. Added visibility:hidden to hide elements we’re listening for, until they have been modified. Better way to delete stylesheet rules
Owner
|
I have added a simple counter to ensure that every listener has a different ID. This should cover half this pull request. I still don't feel right to change what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes/enhancements I made to make your code work for my usage.