Enable CI for pull requests; fix project setup#78
Open
bluenote10 wants to merge 1 commit intocsteinmetz1:mainfrom
Open
Enable CI for pull requests; fix project setup#78bluenote10 wants to merge 1 commit intocsteinmetz1:mainfrom
bluenote10 wants to merge 1 commit intocsteinmetz1:mainfrom
Conversation
|
@csteinmetz1 Would it be possible to merge this pull request? Or to consider alternatives like declaring Currently, the main branch of the repository is broken and can't be installed from the repository, i.e. or fail with the error message mentioned in the PR. |
Owner
|
Hey, I'd like to merge this PR. @bluenote10, is this still the right solution going forward, or is there anything else we need to consider now? |
Author
It worked back then when I'd tested it. Enabling the CI pipeline for PRs should give a definite answer 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enable the CI checks for pull requests to allow adding further checks (type checker, black) in follow-up PRs as a preparation for #77.
While doing so, I've also added a weekly re-run of the CI. This can be useful to see if there are regressions introduced from changes in upstream dependencies (because the CI strategy of this repo is not to fully pin the dependencies, but rather test against a "moving target").
Enabling the checks however revealed that the CI is currently broken, due to a violation in the
pyproject.tomlvssetup.pysetup. Basically executingpip install ".[all]"fails with modern versions of pip with errors like these:Basically pip is complaining about the redundancy that currently exists between the information in the
pyproject.tomlvssetup.py.I have resolved this issues by removing the information from the
pyproject.toml-- note that it is fully redundant to the information specified insetup.py.An alternative would be to resolve the redundancy towards
pyproject.tomlinstead, i.e., basically remove thesetup.pyaltogether. This should be feasible as well. If you prefer, I could also try to resolve the redundancy in this direction.