Skip to content

Improved some debug rules to avoid undoing. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulradzkov wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −28
Open

Improved some debug rules to avoid undoing. #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 7 additions & 28 deletions generic/_debug.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,9 @@
* Images require `alt` attributes, empty `alt`s are fine but should be
* double-checked, no `alt` is bad and is flagged red.
*/
img{
img:not([alt]){
outline:5px solid red;
}
img[alt]{
outline:none;
}
img[alt=""]{
outline:5px solid yellow;
}
Expand All @@ -42,12 +39,9 @@ img[alt=""]{
* Links sometimes, though not always, benefit from `title` attributes. Links
* without are never invalid but it’s a good idea to check.
*/
a{
a:not([title]){
outline:5px solid yellow;
}
a[title]{
outline:none;
}


/**
Expand Down Expand Up @@ -81,12 +75,9 @@ ol{
/**
* It’s always nice to give `th`s `scope` attributes.
*/
th{
th:not([scope]){
outline:5px solid yellow;
}
th[scope]{
outline:none;
}


/**
Expand All @@ -108,35 +99,23 @@ tbody + tfoot{
/**
* Forms require `action` attributes
*/
form{
form:not([action]){
outline:5px solid red;
}
form[action]{
outline:none;
}


/**
* Various form-field types have required attributes. `input`s need `type`
* attributes, `textarea`s need `rows` and `cols` attributes and submit buttons
* need a `value` attribute.
*/
textarea,
input{
textarea:not([rows]):not([cols]),
input:not([type]){
outline:5px solid red;
}
input[type]{
outline:none;
}
textarea[rows][cols]{
outline:none;
}
input[type=submit]{
input[type=submit]:not([value]){
outline:5px solid red;
}
input[type=submit][value]{
outline:none;
}


/**
Expand Down