Skip to content

Conversation

@naasanov
Copy link
Collaborator

@naasanov naasanov commented Apr 13, 2025

Changes

  • Added a dropdown menu for sorting and filtering when column header is clicked
  • Created a ColumnHeader component to handle the display of the column header and dropdown menus
  • Created a FilterDropdown component for adding a filter to a column, with different dropdowns for filtering text versus tags
  • Altered the TagsInput component to have the ability to be used as a filter, conditionally rendering a filter select component that changes filter method
  • Removed filter and sort from the top of the table

Copy link
Member

@12beesinatrenchcoat 12beesinatrenchcoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good afternoon~

  • Filtering doesn't seem to work with the "Requirements" column on the Services page.
  • A way to tell which columns are filtered without having to click through each column would be nice (maybe a filter icon or highlight on the column?)

I'm no longer on the Compass team, so this is just a comment (neither an approval or disapproval). Code quality looks fine, the comments I made are mostly nitpicks.

@naasanov
Copy link
Collaborator Author

Thanks for the review!
Looks like I didn't test thoroughly enough, I'll definitely be better about that. In terms of the filter not working, I think I'll just take the time to make a proper filter for tags, as that's something that would be ideal either way, and that should fix the issue in the process. I'll also add something to distinguish between filtered columns as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants