Conversation
buildstep_inspect.py
Outdated
| """ | ||
|
|
||
| key = 'buildstep_inspect' | ||
| is_allowed_to_fail = True |
There was a problem hiding this comment.
this will be overwritten in buildsteppluginsrunner to False
There was a problem hiding this comment.
Can it happen that users might want to configure multiple build-step plugins?
If yes, then I think it makes sense to allow some of them to fail.
There was a problem hiding this comment.
Ah, we should probably have an arg to tell it to skip this plugin and try the next one.
There was a problem hiding this comment.
arg to skip plugin?
well plugin can always raise inappropriatebuiltstep exception and it will be treated as nothing bad happened
There was a problem hiding this comment.
so if you got plugin just for testing just raise that at the end, and it works
There was a problem hiding this comment.
I've added arg 'inappropriate': set it to True and the plugin will raise InappropriateBuildStepError.
There was a problem hiding this comment.
ahhh ok you meant arg for the plugin
Signed-off-by: Tim Waugh <twaugh@redhat.com>
|
|
||
| For inspecting the workflow state at the build-step phase, the | ||
| `build_inspect.py` plugin is provided. This can be told whether to | ||
| succeed or fail by passing arguments as appropriate when it is |
3 participants
See what you think of this. I was thinking about how to test containerbuildsystem/atomic-reactor#647.