Skip to content

Fix: Objects are not correctly attached to Engineering Change fields #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jens-kuerten merged 3 commits into from
Apr 22, 2025
Merged

Fix: Objects are not correctly attached to Engineering Change fields #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1de90b0
fix: link_objects function to handle individual BaseObject fields, no…
Apr 17, 2025
6e81385
fix comment
Apr 17, 2025
e6a84cd
remove redundant comments
Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions csfunctions/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,17 @@ def link_objects(event: Event):
# e.g. all parts would be in Event.data.parts = list[Part]

for field_name in data.model_fields_set:
# go through each field in data and look for fields that are lists
# objects will always be passed in a list
# go through each field in data and look for fields that are lists of BaseObjects
# or direct BaseObjects

field = getattr(data, field_name)
if isinstance(field, list):
for obj in field:
# the list might contain entries that are not objects, so we check first
if isinstance(obj, BaseObject):
obj.link_objects(data)
elif isinstance(field, BaseObject):
field.link_objects(data)


def execute(function_name: str, request_body: str, function_dir: str = "src") -> str:
Expand Down
Loading