Merged
Conversation
VoronkovMA
previously approved these changes
Nov 10, 2025
Collaborator
VoronkovMA
left a comment
VoronkovMA
left a comment
There was a problem hiding this comment.
I am happy with the changes. All looks good to me.
src/prog/fits.for
Outdated
| do i = 1, nwth | ||
| dewc(i) = max(-50.0,dewc(i)) | ||
| relhum(i) = 100 * exp(b*dewc(i)/(c+dewc(i)))/ | ||
| * exp(b*tempc(i)/(c+tempc(i))) |
Collaborator
There was a problem hiding this comment.
is there a good reason to divide two exponents instead of subtracting the arguments?
Collaborator
Author
There was a problem hiding this comment.
You're right, that's just how the formula was written
src/prog/fits.for
Outdated
| call uvputvrr(tno,'wind',wind(wthid),1) | ||
| call uvputvrr(tno,'winddir',winddir(wthid),1) | ||
| c call uvputvrr(tno,'precipmm',rainmm(wthid),1) | ||
| c call uvputvrr(tno,'smonrms',real(wvr(wthid)),1) |
Collaborator
There was a problem hiding this comment.
I know it is commented out, but we shouldn't use WVR for seeing monitor data. There is no good way to capture seeing monitor data in our ASDMs at the moment (and it won't get to fits anyway), but this is beyond the scope of this ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added temperature, pressure, wind speed, direction and humidity calculated from dew point.