replication: add replication state to GetVolumeReplicationInfo response #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Rakshith-R
previously requested changes
Apr 22, 2025
Member
Rakshith-R
left a comment
Rakshith-R
left a comment
There was a problem hiding this comment.
More discussion is required before deciding on this particular approach.
nixpanic
reviewed
Apr 22, 2025
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
2 times, most recently
from
f7da44e to
34637e3
Compare
nixpanic
reviewed
May 15, 2025
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
from
34637e3 to
d0251af
Compare
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
from
d0251af to
9c92b24
Compare
…oResponse add status and status_message to GetVolumeReplicationInfoResponse that describes the current replication state to the end user. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Nikhil-Ladha
force-pushed
the
add-state-to-info-api
branch
from
9c92b24 to
d4b08f9
Compare
nixpanic
approved these changes
May 28, 2025
Madhu-1
approved these changes
May 28, 2025
Member
Madhu-1
left a comment
Madhu-1
left a comment
There was a problem hiding this comment.
I assume this will not cause any problem when both server and clients are on different versions
Member
|
@Rakshith-R You have requested changed on this PR, PTAL |
Contributor
Author
|
@Rakshith-R can you please take a look and update your review accordingly? |
nixpanic
dismissed
Rakshith-R’s stale review
There has been quite some discussion about this, I hope it addresses Rakshiths concerns too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
replication_stateto GetVolumeReplicationInfo response.Fixes: #78