fix: pass squadFolder to GitHubIssuesService for .squad workspaces#68
Merged
csharpfritz merged 1 commit intocsharpfritz:mainfrom Feb 23, 2026
Merged
Conversation
GitHubIssuesService created its own TeamMdService with the default '.ai-team' folder, ignoring the runtime-detected squad folder. This caused all GitHub issue and milestone fetches to silently return empty results in workspaces using the new .squad/ folder structure. This was missed in commit 5c01e1f which fixed the same issue in four other places. Added squadFolder option to GitHubIssuesServiceOptions and tests verifying both .squad detection and default .ai-team fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workspaces using the new
.squad/folder structure (instead of legacy.ai-team/) show 0 issues, 0 milestones, and all members idle on the Squad Dashboard — even when the GitHub repo has issues withsquad:{member}labels and milestones configured.The Team tab shows all members but with
0 open · 0 closed · 0 in progress, and the Burndown tab shows "No milestone data available."Root Cause
GitHubIssuesServicecreates its ownTeamMdService()with the default.ai-teamfolder (line 69), ignoring the runtime-detected squad folder. When the workspace uses.squad/, the service looks for.ai-team/team.mdwhich doesn't exist, sogetIssueSource()returnsnulland all issue/milestone fetches silently return empty arrays.This was missed in commit 5c01e1f which fixed the same
.ai-teamhardcoding in four other places (SquadDataProvider, SquadDashboardWebview, DecisionsTreeProvider, TeamTreeProvider).Fix
squadFolderoption toGitHubIssuesServiceOptionsnew TeamMdService(options.squadFolder)— falls back to.ai-teamwhen unset (backward compatible)squadFolderNamewhen constructing the serviceTests Added
.squadfolder team.md is found whensquadFolder: '\.squad'is passed.squad/team.md(confirms the bug)squadFolderthrough to internalTeamMdServicesquadFolderremains.ai-teamfor backward compatibilityAll 1026 existing tests continue to pass.