Add type annotations to library code#459
Merged
csernazs merged 4 commits intocsernazs:masterfrom Jan 30, 2026
Merged
Conversation
HayaoSuzuki
force-pushed
the
fix/add-type-hint
branch
from
a316cd4 to
7a27540
Compare
csernazs
reviewed
Jan 29, 2026
pytest_httpserver/httpserver.py
Outdated
| return response | ||
|
|
||
| def __enter__(self): | ||
| def __enter__(self) -> HTTPServerBase: # noqa: PYI034 |
Owner
There was a problem hiding this comment.
Could this be Self?
Suggested change
| def __enter__(self) -> HTTPServerBase: # noqa: PYI034 | |
| def __enter__(self) -> Self: |
Owner
There was a problem hiding this comment.
Thanks for the PR! I submitted my comments above.
Contributor
Author
There was a problem hiding this comment.
Done. I initially avoided using Self because it's only available in Python 3.11+, and I didn't want to add extra dependencies. However, I've now added typing_extensions as a dev dependency (for Python < 3.11) to enable Self.
csernazs
approved these changes
Jan 30, 2026
Owner
|
Thank you very much for this PR, this makes the code significantly better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type hints to pass
mypy --strictonpytest_httpserver/.