Development

[michael-pisman]

This pull request introduces several updates to the authentication flow and code structure, focusing on improving token refresh functionality, refining exception handling, and enhancing code readability. The changes include modifications to the refresh_token_with_clientID function, updates to the authentication route, and various formatting improvements in the documents module.

Authentication Flow Updates:

• Updated refresh_token_with_clientID to accept refresh_token as a direct parameter instead of parsing it from the body, simplifying the function's input handling (src/unipoll_api/actions/authentication.py).
• Replaced exceptions with missing parentheses in InvalidAccessToken, InvalidClientID, and refreshTokenExpired to ensure proper exception instantiation (src/unipoll_api/actions/authentication.py) [1] [2].

Route Updates:

• Modified the /jwt/postman_refresh endpoint to use Form parameters (refresh_token and grant_type) instead of a JSON body, aligning with OAuth2 standards (src/unipoll_api/routes/authentication.py) [1] [2].
• Re-enabled the import of authentication schemas for better schema validation (src/unipoll_api/routes/authentication.py).

Code Formatting and Readability:

• Reformatted multi-line function definitions and method calls for better readability in src/unipoll_api/documents.py [1] [2] [3] [4] [5] [6] [7].
• Reorganized imports in src/unipoll_api/documents.py and src/unipoll_api/routes/authentication.py to follow PEP 8 import grouping standards [1] [2].

[Copilot]

Pull Request Overview

This pull request improves the authentication flow by standardizing OAuth2 token refresh endpoints and enhances code readability through formatting improvements. The changes focus on simplifying the refresh token function interface and aligning with OAuth2 standards.

• Updates the refresh token endpoint to use proper Form parameters instead of parsing request bodies
• Fixes exception handling by adding missing parentheses to exception instantiations
• Reformats code across multiple files for better readability and PEP 8 compliance

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/unipoll_api/routes/authentication.py	Updates refresh token endpoint to use Form parameters and re-enables authentication schemas import
src/unipoll_api/actions/authentication.py	Simplifies refresh_token_with_clientID function signature and fixes exception instantiation
src/unipoll_api/documents.py	Reformats imports and function definitions for improved code readability

[Copilot]

Exception class is not being instantiated. Should be raise AuthExceptions.InvalidAccessToken() to properly raise the exception.

Suggested change

	raise AuthExceptions.InvalidAccessToken
	raise AuthExceptions.InvalidAccessToken()

[Copilot]

Exception class is not being instantiated. Should be raise AuthExceptions.InvalidClientID() to properly raise the exception.

Suggested change

	raise AuthExceptions.InvalidClientID
	raise AuthExceptions.InvalidClientID()

[Copilot]

Exception class is not being instantiated. Should be raise AuthExceptions.refreshTokenExpired() to properly raise the exception.

Suggested change

	raise AuthExceptions.refreshTokenExpired
	raise AuthExceptions.refreshTokenExpired()

[Copilot]

Exception class is not being instantiated properly. Should be raise ResourceNotFound(...) to properly raise the exception.