fix: bump macOS SPM deployment target from 10.14 to 10.15 for SFTranscription#664
Open
buryitaway-boop wants to merge 1 commit intocsdcorp:mainfrom
Open
fix: bump macOS SPM deployment target from 10.14 to 10.15 for SFTranscription#664buryitaway-boop wants to merge 1 commit intocsdcorp:mainfrom
buryitaway-boop wants to merge 1 commit intocsdcorp:mainfrom
Conversation
|
This fix is possible, but the current code in the main branch also already works. In any case, I think your change is also good. The podspec already forces 10.15, so your pull request brings consistency to SPM side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
speech_to_text7.3.0 fails to compile on macOS when using Swift Package Manager (SPM) instead of CocoaPods.The
Package.swiftdeclares.macOS("10.14")but several types inSpeechToTextPlugin.swift(e.g.SFTranscription) require macOS 10.15+.This causes Xcode to emit:
Related issues: #662, #649
Fix
One-line change: bump
.macOS("10.14")→.macOS("10.15")inspeech_to_text/darwin/speech_to_text/Package.swift.This aligns the SPM minimum deployment target with the actual API requirements of the plugin code.