-
Notifications
You must be signed in to change notification settings - Fork 1
489 data table page #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
489 data table page #565
Conversation
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 60. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ronjakrg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich habe mal etwas ausführlicher drüber geschaut. Sehr viele nice Ideen und die Benutzung ist soo viel besser als vorher! Habe ein paar kleinere Anmerkungen gemacht :)
sarahvgls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ein paar Kommentare noch von meiner Seite, recht wenig zum Frontend hier, da das ja dann vermutlich sowieso noch mal verändert werden muss
|
Vielen Dank für das ganze Feedback, ich habe viel davon umgesetzt und implementiert :) |
|
Danke für die Änderungen! Sieht voll gut aus so!! |
Description
fixes #489
Enable a fast datatable-page via server-side paging, searching and sorting. Also fix small bugs
Changes
big changes:
datatables-control.js
tables.html
mid changes:
views.py
views_helper.py
small changes:
run.py
steps.py
Testing
PR checklist
Development
Mergeability
blackCode review