Skip to content

Conversation

@noLeonardo
Copy link
Collaborator

Description

fixes #489
Enable a fast datatable-page via server-side paging, searching and sorting. Also fix small bugs

Changes

big changes:
datatables-control.js
tables.html

mid changes:
views.py
views_helper.py

small changes:
run.py
steps.py

Testing

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  disk_operator.py
  run.py 193
  run_helper.py
  steps.py 77-78, 162, 193
  protzilla/data_analysis
  plots.py
  protein_graphs.py
  ptm_analysis.py 56, 123-125
  protzilla/data_integration
  database_query.py 113-119
  di_plots.py
  enrichment_analysis.py
  protzilla/data_preprocessing
  imputation.py
  plots.py
  protzilla/importing
  ms_data_import.py 122, 276
  protzilla/methods
  data_analysis.py 21, 41, 123, 177, 200, 249, 284, 597, 615, 636, 651
  importing.py 123
  protzilla/utilities
  utilities.py 184
  ui/main
  settings.py 131
  ui/runs
  fields.py
  views.py 19, 44, 80-81, 187, 524-554, 560-578, 734, 739-743
  views_helper.py 2, 124-175
  ui/runs/forms
  base.py 107
  custom_fields.py 119
  data_analysis.py 323-327, 384, 414, 450, 473, 1188, 1226, 1248
  data_integration.py
  ui/settings
  plot_template.py 84
Project Total  

The report is truncated to 25 files out of 60. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@ronjakrg ronjakrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe mal etwas ausführlicher drüber geschaut. Sehr viele nice Ideen und die Benutzung ist soo viel besser als vorher! Habe ein paar kleinere Anmerkungen gemacht :)

Copy link
Collaborator

@sarahvgls sarahvgls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ein paar Kommentare noch von meiner Seite, recht wenig zum Frontend hier, da das ja dann vermutlich sowieso noch mal verändert werden muss

@noLeonardo
Copy link
Collaborator Author

Vielen Dank für das ganze Feedback, ich habe viel davon umgesetzt und implementiert :)

@sarahvgls
Copy link
Collaborator

Danke für die Änderungen! Sieht voll gut aus so!!

@noLeonardo noLeonardo requested a review from ronjakrg February 17, 2025 13:26
@noLeonardo noLeonardo merged commit a9bc8d0 into dev Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade the "view table"

4 participants