Update __init__.py in half to include better help messages.#60
Open
Explodey-Wolf wants to merge 1 commit intocs50:2023/xfrom
Open
Update __init__.py in half to include better help messages.#60Explodey-Wolf wants to merge 1 commit intocs50:2023/xfrom
Explodey-Wolf wants to merge 1 commit intocs50:2023/xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, help messages in the half problem were incredibly erroneous. If you were to get it wrong, it would say:
Expected 64.00, not 32.00. The problem with this message is that check50 also expects a dollar sign in the number, and the number can be anywhere in the string. This PR can hopefully help clear up issues where people remove the dollar sign accidentally, and are confused when check50 errors with the output it 'expects'. It now uses check50.Missing() instead of just the default stdout().