Draft
Conversation
Open
Collaborator
|
will this eventually implement something similar to a |
Collaborator
Author
|
i rebased this branch to main for the changes made in #34, hence the force-push |
jpappel
reviewed
Nov 21, 2024
Collaborator
|
why were the decorators removed in 9828529, doing so causes the non-AWS deploys to fail. If there is an issue of making a request to often for the configuration value, it can be cached by doing something like @property
def SOME_VAL():
if self._SOME_VAL is None:
self._SOME_VAL = value_generator()
return self._SOME_VAL |
Collaborator
|
Upon looking further inspection, removing the properties is what caused the tests to fail |
Collaborator
Author
|
I removed the properties because the cognito library would not end up getting the value, and got a so when logging in the client_id is |
Collaborator
|
Is this still waiting on anything? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a bare-bones cognito auth flow.