[PSQ] Allow more control over AEAD nonces for transport#1339
Draft
jschneider-bensch wants to merge 3 commits intomainfrom
Draft
[PSQ] Allow more control over AEAD nonces for transport#1339jschneider-bensch wants to merge 3 commits intomainfrom
jschneider-bensch wants to merge 3 commits intomainfrom
Conversation
jschneider-bensch
force-pushed
the
jonas/psq-robust-nonces
branch
from
03587bf to
ad52c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes AEAD decryption in
libcrux-psqsuch that a decryption error will leave the receiver nonce unchanged. This is so the decrypting party can aks for re-transmission of a faulty ciphertext and re-attempt decryption. To do so safely requires that the underlying AEAD implementations do not reveal anything other than the decryption error, which is the case for the ChaCha20Poly1305 and AES-GCM implementations used here.The PR also adds a new optional feature
nonce-controlwhich gives the application calling intolibcrux-psqfull control over the nonces used inTransportchannels. This makes it the application's responsibility to avoid nonce re-use.Closes #1325.
Closes #1326.