Skip to content

Fix hax compilation of crates relying on classification traits#1312

Open
maximebuyse wants to merge 2 commits intomainfrom
fix-hax-extraction-cfg
Open

Fix hax compilation of crates relying on classification traits#1312
maximebuyse wants to merge 2 commits intomainfrom
fix-hax-extraction-cfg

Conversation

@maximebuyse
Copy link
Contributor

@maximebuyse maximebuyse commented Feb 4, 2026

The fix is to use hax_lib::exclude instead of cfg(not(hax)) to exclude the unsupported items from hax extraction, without breaking compilation under the hax cfg.

This PR replaces #1263

[skip changelog]

@maximebuyse maximebuyse force-pushed the fix-hax-extraction-cfg branch from 0a7e61f to ed13c30 Compare February 4, 2026 15:18
@maximebuyse maximebuyse marked this pull request as ready for review February 4, 2026 15:52
@maximebuyse maximebuyse requested a review from a team as a code owner February 4, 2026 15:52
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @jschneider-bensch do we have other crates where we should fix this? Also, should we add a dummy crate (or get #1259 in) to have a test in the repo to make sure we don't break this again?

@jschneider-bensch
Copy link
Collaborator

do we have other crates where we should fix this? Also, should we add a dummy crate (or get #1259 in) to have a test in the repo to make sure we don't break this again?

It is worth checking to avoid dependency trouble in the future, for sure. We should get #1259 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments