Alm plugin #143
Open
Alm plugin #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debych
requested changes
Mar 25, 2025
debych
previously requested changes
Mar 26, 2025
debych
requested changes
Mar 27, 2025
| slowTwapTick = _getTwapTick(slowTwapPeriod); | ||
| fastTwapTick = _getTwapTick(fastTwapPeriod); | ||
| } else { | ||
| failedToObtainTWAP = true; |
Contributor
There was a problem hiding this comment.
IMO filedToObtainTWAP handling should be completely removed then. If the only case when it is true is before slowTwapPeriod then we perhaps should just skip rebalance and not set pause and Special state
| require(!isAlmInitialized, 'Already initialized'); | ||
| isAlmInitialized = true; | ||
| paused = false; | ||
| // TODO: добавить require'ов |
Contributor
There was a problem hiding this comment.
Add require statements:
- vault is not zero
- thresholds validation
debych
reviewed
Mar 27, 2025
debych
requested changes
Mar 28, 2025
debych
reviewed
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.