Add a new API to retrieve both nearest indices and distances#16
Open
GiBg1aN wants to merge 1 commit intocrvs:masterfrom
Open
Add a new API to retrieve both nearest indices and distances#16GiBg1aN wants to merge 1 commit intocrvs:masterfrom
GiBg1aN wants to merge 1 commit intocrvs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thank you for your clean and concise implementation of kd-trees which does not rely on bigger libraries.
Sometimes when querying trees it might be useful to retrieve both indices and distances of points like SciPy does.
I added a new API to your implementation starting from your code, but you could also return both a standard, without adding a new primitive (even though this may break compatibility).