Allow specifying custom scales and iterations#11
Open
GusRuss89 wants to merge 2 commits intocrowsonkb:masterfrom
Open
Allow specifying custom scales and iterations#11GusRuss89 wants to merge 2 commits intocrowsonkb:masterfrom
GusRuss89 wants to merge 2 commits intocrowsonkb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to optionally set custom scales and their respective iterations.
Previously, if you specify
--end-scaleand--iterationsvia the cli, all generated scales will run for the same number of iterations (apart from the initial scale which is a separate parameter).This isn't always desirable. Larger scales can often get away with far fewer iterations than smaller scales. With this PR you can specify scales and iterations together in an array of tuples. E.g.
This would run the 256px scale and 512px scale for 1000 iterations, 1024px for 500 iterations, 1256px for 300 and 1600px for 200. The output quality is similar and the run time is reduced massively.
This PR doesn't include an update to the CLI to set this parameter, it's currently only available when interfacing with
StyleTransferfrom another python file. Setting scales and iterations the previous way is still supported, just don't include thescalesargument in the call tostylize.