Skip to content

Conversation

@MHIZokuchi
Copy link
Contributor

  • Add CommentAttachment and CommentAttachmentRequest models
  • Update AddStringCommentRequest to support attachments parameter
  • Update StringComment to include attachments in response
  • Implement DeleteCommentAttachment endpoint
  • Add unit test for DeleteCommentAttachment method

Closes #353

- Add CommentAttachment and CommentAttachmentRequest models
- Update AddStringCommentRequest to support attachments parameter
- Update StringComment to include attachments in response
- Implement DeleteCommentAttachment endpoint
- Add unit test for DeleteCommentAttachment method

Closes crowdin#353
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.48%. Comparing base (f45d418) to head (59285a5).
⚠️ Report is 175 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Crowdin.Api/StringComments/CommentAttachment.cs 0.00% 8 Missing ⚠️
...wdin.Api/StringComments/AddStringCommentRequest.cs 0.00% 1 Missing ⚠️
...din.Api/StringComments/CommentAttachmentRequest.cs 0.00% 1 Missing ⚠️
src/Crowdin.Api/StringComments/StringComment.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #355       +/-   ##
===========================================
+ Coverage   50.38%   68.48%   +18.10%     
===========================================
  Files         277      448      +171     
  Lines        3688     6849     +3161     
  Branches        0      563      +563     
===========================================
+ Hits         1858     4690     +2832     
- Misses       1830     2110      +280     
- Partials        0       49       +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MHIZokuchi thank you!

@andrii-bodnar andrii-bodnar merged commit 3570e2f into crowdin:main Dec 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for String Comment Attachments

2 participants