haproxy: Check for existance of "content[:stick]" (bsc#1062889)#258
Merged
stefannica merged 1 commit intocrowbar:masterfrom Nov 6, 2017
toabctl:bsc-1062889
Merged
haproxy: Check for existance of "content[:stick]" (bsc#1062889)#258stefannica merged 1 commit intocrowbar:masterfrom toabctl:bsc-1062889
stefannica merged 1 commit intocrowbar:masterfrom
toabctl:bsc-1062889
Conversation
aspiers
previously approved these changes
Oct 12, 2017
nicolasbock
previously approved these changes
Oct 12, 2017
stefannica
dismissed stale reviews from jsuchome, nicolasbock, and aspiers
via
cc02ab5
stefannica
changed the title
After a cowbar-ha update, the 'stick' attribute introduced in commit #74115353 is missing from the existing node[:haproxy][sections] entries, which may result in errors such as: Chef::Mixin::Template::TemplateError ------------------------------------ undefined method `[]' for nil:NilClass This commit adds checks for the existence of the 'stick' attribute before dereferencing it.
bmwiedemann
approved these changes
Nov 6, 2017
jsuchome
approved these changes
Nov 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a cowbar-ha update, the 'stick' attribute introduced in
PR #208 is missing from the existing node[:haproxy][sections]
entries, which may result in errors such as:
This PR adds checks for the existence of the 'stick' attribute
before dereferencing it.