This repository was archived by the owner on Dec 4, 2018. It is now read-only.
[needs testing] fix #maintenance_mode? return value#149
Closed
aspiers wants to merge 1 commit intocrowbar:masterfrom
Closed
[needs testing] fix #maintenance_mode? return value#149aspiers wants to merge 1 commit intocrowbar:masterfrom
aspiers wants to merge 1 commit intocrowbar:masterfrom
Conversation
|
Not tested but LGTM |
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 11, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to aspiers/suse-cloud-vagrant
that referenced
this pull request
Nov 11, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to aspiers/suse-cloud-vagrant
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
Nov 12, 2014
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
aspiers
referenced
this pull request
in vuntz/suse-cloud-vagrant
Nov 18, 2014
There is no strict need to start openais after the removal of /var/spool/corosync/block_automatic_start, as chef-client will start it.
Member
Author
There was a problem hiding this comment.
I really don't like multi-line unless - I find it more effort for the brain to understand.
Member
Author
|
This change is good but the commit message is wrong - it's not necessary for cluster startup. I think I got confused in Paris due to lack of sleep. |
aspiers
force-pushed
the
fix/cluster-join
branch
from
54db896 to
7c5ffa9
Compare
aspiers
changed the title
Member
Author
|
OK commit message is correct now. |
Make #maintenance_mode? return a sensible value even when openais is down or uninstalled. This is especially helpful when it is invoked by Chef's start_handler.
aspiers
force-pushed
the
fix/cluster-join
branch
from
7c5ffa9 to
bdbfbf1
Compare
Member
|
@aspiers: has this been tested? Also, I'm a bit unclear in which case this actually matters, since I don't remember seeing anything wrong because of this. |
Member
Author
|
@vuntz I'll test again. It's just a cleaner way of handling the corner cases; I don't expect it will be hit except in rare circumstances. But I guess it might also result in cleaner logs. |
aspiers
pushed a commit
to SUSE-Cloud/suse-cloud-appliances
that referenced
this pull request
May 11, 2015
See crowbar/barclamp-pacemaker#149 Not yet sure if this helps.
Member
|
@aspiers, this repository got merged into crowbar-ha. |
Member
Author
|
Superceded by crowbar/crowbar-ha#13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
#maintenance_mode?return a sensible value even when openais is down or uninstalled. This is especially helpful when it is invoked by Chef'sstart_handler.