Skip to content

Expose composite resource ready state in function response#496

Open
tenitski wants to merge 7 commits intocrossplane-contrib:mainfrom
tenitski:composite-resource-ready-state
Open

Expose composite resource ready state in function response#496
tenitski wants to merge 7 commits intocrossplane-contrib:mainfrom
tenitski:composite-resource-ready-state

Conversation

@tenitski
Copy link

@tenitski tenitski commented Oct 21, 2025

Description of your changes

Allows to set composite resource Ready state via annotation gotemplating.fn.crossplane.io/ready, similarly how this is done for composed resources.

This PR introduces a new usage scenario for unnamed composite resources. Previously, it was used only for passing Status; now, it also supports passing the gotemplating.fn.crossplane.io/ready annotation.

The additional change in this PR is that if Status is empty and a resource was used solely to pass the annotation, we will not set an empty Status value. Before it was not a problem because Status was always there.

Fixes #153

I have:

Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
@tenitski tenitski marked this pull request as draft October 21, 2025 01:00
Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
@tenitski tenitski marked this pull request as ready for review October 21, 2025 01:16
Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
@tenitski tenitski mentioned this pull request Oct 21, 2025
2 tasks
@tenitski
Copy link
Author

@bobh66 now after main was updated to SDK 0.5.0 all deps for my branch are there and it is ready for review.

@bobh66
Copy link
Collaborator

bobh66 commented Dec 19, 2025

Thanks @tenitski - can you give a few more details on what's changing? It seems like a lot of code changes that are unrelated to the composite readiness. It appears to have something to do with merging status updates? Thanks

@tenitski
Copy link
Author

@bobh66 i've updated the PR description to clarify the changes

@tenitski
Copy link
Author

Still looking forward to have this PR reviewed and merged. We have been running this code in production for over six months now.

@tenitski
Copy link
Author

tenitski commented Feb 2, 2026

@bobh66 👋

@tenitski
Copy link
Author

tenitski commented Feb 4, 2026

@bobh66 I fixed lint & unit test, I still see one lint error but it exists in main as well 🤷

@tenitski
Copy link
Author

tenitski commented Feb 4, 2026

Yay all green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set the Ready condition on the composite

2 participants