Make CLI validation commands appear on the web#117
Open
Conversation
Contributor
Author
|
Just to provide a bit of reasoning behind this solution. I introduced a script |
mukrop
requested changes
Oct 6, 2021
Member
mukrop
left a comment
There was a problem hiding this comment.
Seems nice. Two minor points to improve:
- The copy script uses command-line arguments. Please document these somewhere, at least briefly. My preference would be directly in the script (outputting short description when run with an inappropriate number of orguments). The arguments numberr check (I suggest to add) will prevent errors when make call to the script is done with nonexistent variabled (and thus only one or no argument to the script).
_data/certs.ymlseems to me a weird name for aggregating the validation commands (as there are no certs in it and only borderline information about certs). What about_data/cli-validation.ymlor something in this direction? (Sidenote: I do agree that having the validation commands in thevconfig.ymlfile is the right way to go.)
Member
|
Ah, and I see conflicts by merging the lowercase names first. Is it simple to rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dropped the commands when shifting to the new system but agreed it would be nice to have them back. Solves #105.