Flatten the generated zip archives and include individual certs#116
Open
Flatten the generated zip archives and include individual certs#116
Conversation
mukrop
reviewed
Oct 6, 2021
Member
mukrop
left a comment
There was a problem hiding this comment.
Two questions before approval:
- Is generating a chain file and then splitting it not too complicated? Did you not consider adjusting the generating scripts to create individual files? Then, the chain can be easily created by concatenation of cert files (possibly even directly in Make). I know this would introduce more changes (all generating scripts would need to be changed), but I find it a more modular design (with fewer utility scripts).
- (Only relevant if the previous question is dismissed.) Your Makefile changes hardcode the folder name
tmpon multiple places. I'd prefer having it as a variable. Similarly, the new utility script hardcodes the namesendpoint.pemandintermediate[num].pem– this may be OK, though I was hesitant if hardcoding the names will not cause trouble later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we export each chain as a single file
chain.pemtogether with the root certroot.pem. This makes it hard to validate manually using command-line OpenSSL, since it only accepts a single cert per file.This PR flattens the archive structure (no subdirectories as is the case now) and also exports each certificate separately.
An example archive may look like this:
- chain.pem (contains endpoint and two intermediate CA certs)
- root.pem
- endpoint.pem
- intermediate1.pem
- intermediate2.pem
Solves #104.