Preparing for EUCC: Moving convert and extraction functions to common files #550
+238
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second pull requests which will involve moving shared functionality (for both CC and EUCC) into common files.
These pull requests will be structured according to the individual parts of the pipeline. This one includes convert and extractions functions.
! I had a problem with multiprocessing. After moving convert_report_pdf, convert_st_pdf, convert_cert_pdf functions outside of the CCCertificate class to a common file, a function which handles multiprocession (convert_pdfs) had a problem with these functions not being static anymore. The easiest solution was currently to move them to dataset/common.py from sample/common.py ! Maybe I will find easier solution in the upcoming weeks.