feat: add e2e testcases functional test and sample#122
Merged
iwillspeak merged 4 commits intomainfrom Feb 13, 2026
Merged
Conversation
Member
iwillspeak
commented
Feb 13, 2026
iwillspeak
commented
- Update athena-protobufs submodule to include testcases/
- Add functional test for integrator_sample testcases
- Add e2e-testcases sample with CLI for running test sets
- Support multiple test sets: integrator_sample, benign_model, live_model
- Configurable tolerance for floating-point comparisons
- Update athena-protobufs submodule to include testcases/ - Add functional test for integrator_sample testcases - Add e2e-testcases sample with CLI for running test sets - Support multiple test sets: integrator_sample, benign_model, live_model - Configurable tolerance for floating-point comparisons
iwillspeak
assigned
anna-singleton-resolver and
iwillspeak and unassigned
anna-singleton-resolver
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end testing infrastructure using shared test cases from the athena-protobufs submodule. It introduces both a standalone CLI tool and a functional test suite that validate classification results against expected outputs.
Changes:
- Updated athena-protobufs submodule to include testcases directory
- Added e2e-testcases sample with CLI for running test sets against the classification service
- Added functional test suite that validates integrator_sample testcases with configurable tolerance
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| athena-protobufs | Updated submodule to version containing testcases directory |
| samples/e2e-testcases/package.json | Package configuration for the e2e test runner with tsx as dev dependency |
| samples/e2e-testcases/tsconfig.json | TypeScript configuration targeting ES2022 with NodeNext module resolution |
| samples/e2e-testcases/index.ts | CLI application for running test sets with configurable tolerance and verbose output |
| samples/e2e-testcases/README.md | Documentation for the e2e test runner with usage examples and configuration details |
| samples/README.md | Updated samples overview to include the new e2e-testcases tool |
| tests/functional/e2e.functional.test.ts | Vitest-based functional test that validates classification against integrator_sample testcases |
Files not reviewed (1)
- samples/e2e-testcases/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
February 13, 2026 12:45
- Add AthenaAudience type, VALID_AUDIENCES array, and parseAudience() function to authenticationManager.ts - Export from SDK index for consumer use - Update e2e test, samples to use shared parseAudience function - Removes unsafe type assertions in favor of runtime validation
Avoids issues with manual arg parsing.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- samples/e2e-testcases/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnnyWombwell
approved these changes
Feb 13, 2026
anna-singleton-resolver
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.