fixed an overflow error caused by choosing too small a type to store variables#4
Open
raabh wants to merge 1 commit intocrillab:mainfrom
Open
fixed an overflow error caused by choosing too small a type to store variables#4raabh wants to merge 1 commit intocrillab:mainfrom
raabh wants to merge 1 commit intocrillab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is, in my best belief, the solution to the overflow bug. Depending on the number of variables, d4v2 chooses an appropriate type to save RAM.
It loses one bit because d4v2 encodes variables in unsigned types but adds the sign by hand afterward. Hence, d4v2 needs to "upgrade" to the next bigger type earlier.
This should fix my recently opened issue