Open
Conversation
Comment on lines
+160
to
+161
| var cycleSubStack = [Any.Type]() | ||
| var hitCount = [String:Int]() |
There was a problem hiding this comment.
styling:
var cycleSubStack: [Any.Type] = []
var hitCount: [String:Int] = []
Author
There was a problem hiding this comment.
?? I'm not aware of us having a preference on this one.
Its not like we do
let foo: Foo = Foo() either...
There was a problem hiding this comment.
well, it's confusing but we do reference two style guides in our docs unfortunately. One of them is more kept up to date and more comprehensive. That one says that for empty arrays / dictionaries, we should inform the type and initialize with the short form, which is either [] or [:]
|
All minor stuff .. great change John, this will help a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had our call stack blowing up regularly.
Add a new Dip Error and reporting to help identify recursive errors.
It can print out a report like the following:
The Max is defaulted to 100. Can be configured statically.