Make gen more strict about being called exactly once#8
Open
TomiBelan wants to merge 3 commits intocreationix:masterfrom
Open
Make gen more strict about being called exactly once#8TomiBelan wants to merge 3 commits intocreationix:masterfrom
TomiBelan wants to merge 3 commits intocreationix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is branched off from #7. You probably want to look at 0eeee5f, not the combined diff of both this and #7. If you want to merge it without #7, tell me and I'll rebase it.
What this commit does, and why:
gen()(null, value). You're not supposed to do that: it circumvents thedonecheck in resume. The new checks correctly detected that the tests didn't call gen before yielding nor yield a continuable.yielded = trueline fromcheck.