Skip to content

Use instanceof instead of typeof #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radford wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use instanceof instead of typeof #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = run;

function run(generator, callback) {
var iterator;
if (typeof generator === "function") {
if (generator instanceof Function) {
// Pass in resume for no-wrap function calls
iterator = generator(resume);
}
Expand Down Expand Up @@ -45,19 +45,19 @@ function run(generator, callback) {

function start(cont) {
// Pass in resume to continuables if one was yielded.
if (typeof cont === "function") return cont(resume());
if (cont instanceof Function) return cont(resume());
// If an array of continuables is yielded, run in parallel
if (Array.isArray(cont)) {
for (var i = 0, l = cont.length; i < l; ++i) {
if (typeof cont[i] !== "function") return;
if (!(cont[i] instanceof Function)) return;
}
return parallel(cont, resume());
}
// Also run hash of continuables in parallel, but name results.
if (typeof cont === "object" && Object.getPrototypeOf(cont) === Object.prototype) {
if (cont instanceof Object) {
var keys = Object.keys(cont);
for (var i = 0, l = keys.length; i < l; ++i) {
if (typeof cont[keys[i]] !== "function") return;
if (!(cont[keys[i]] instanceof Function)) return;
}
return parallelNamed(keys, cont, resume());
}
Expand Down