Skip to content

Fix Ruby 3.4 frozen string literal warning #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lewispb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Ruby 3.4 frozen string literal warning #4

lewispb wants to merge 1 commit into from

Conversation

@lewispb
Copy link

@lewispb lewispb commented Dec 12, 2025 •
edited
Loading

  • Use array accumulation instead of string mutation in encode method to avoid warning about literal string being frozen in the future
/home/lewis/.local/share/mise/installs/ruby/3.4.7/lib/ruby/gems/3.4.0/gems/geohash_ruby-1.0.2/lib/geohash_ruby.rb:95:
warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
  • Add basic minitest suite, run rake test
  • Update gemspec dev dependencies (remove version constraints)

@lewispb
Fix Ruby 3.4 frozen string literal warning
48e70a7 
Use array accumulation instead of string mutation in encode method
to avoid warning about literal string being frozen in the future.

Also adds a basic test and updates gemspec dev dependencies.
@lewispb lewispb force-pushed the fix-ruby-34-warnings branch from 21b00f3 to 48e70a7 Compare December 12, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lewispb