Merged
Conversation
|
jdw-creare
approved these changes
Jun 6, 2025
Contributor
jdw-creare
left a comment
There was a problem hiding this comment.
Thanks Sam, this looks great!
I think this kind of change is exactly what SonarQube is encouraging to reduce cognitive complexity. I like how you picked sections of the long methods to break out into their own methods.
I think if you were adding a new chunk of code, I'd request some additional docstrings. But since this is meant to be a light-touch refactor, there's no need to go through the effort to sort those out. I"ll merge!
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resolve the SonarQube findings, apologies in advance for size of PR. A lot of the changes are autoformatting taking over on saving files (let me know if you want me to remove them). Major changes are for cognitive complexity and splitting large functions into multiple pieces.