Skip to content

Fix SonarQube Findings#9

Merged
jdw-creare merged 1 commit intodevelopfrom
chore/linting
Jun 6, 2025
Merged

Fix SonarQube Findings#9
jdw-creare merged 1 commit intodevelopfrom
chore/linting

Conversation

@scranford1
Copy link
Copy Markdown

Resolve the SonarQube findings, apologies in advance for size of PR. A lot of the changes are autoformatting taking over on saving files (let me know if you want me to remove them). Major changes are for cognitive complexity and splitting large functions into multiple pieces.

@scranford1 scranford1 requested a review from jdw-creare June 5, 2025 14:48
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

@jdw-creare jdw-creare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam, this looks great!

I think this kind of change is exactly what SonarQube is encouraging to reduce cognitive complexity. I like how you picked sections of the long methods to break out into their own methods.

I think if you were adding a new chunk of code, I'd request some additional docstrings. But since this is meant to be a light-touch refactor, there's no need to go through the effort to sort those out. I"ll merge!

Thanks!

@jdw-creare jdw-creare merged commit 0880db6 into develop Jun 6, 2025
3 checks passed
@scranford1 scranford1 deleted the chore/linting branch February 3, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants