Add MACOSX_DEPLOYMENT_TARGET to env.ini

[crazywhalecc]

What does this PR do?

Closes #1008

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

• If you modified *.php or *.json, run them locally to ensure your changes are valid:
  • composer cs-fix
  • composer analyse
  • composer test
  • bin/spc dev:sort-config
• If it's an extension or dependency update, please ensure the following:
  • Add your test combination to src/globals/test-extensions.php.
  • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

[henderkes]

Shouldn't we set this to current version by default?

[crazywhalecc]

Shouldn't we set this to current version by default?

Using current version will not fix anything and causes portability issue for old macOS. Setting it to the current version is the same as not setting the variable.

[henderkes]

I know, but we also don't compile for old glibc versions on linux by default either. Users should overwrite the variable if they need compatibility with old macos.

[crazywhalecc]

I know, but we also don't compile for old glibc versions on linux by default either. Users should overwrite the variable if they need compatibility with old macos.

My understanding is that we've defaulted to maximum portability support on Linux (using musl-static), and that should be true for macOS as well. This is different from the glibc issue.

macOS 12 is the minimum version supported by modern toolchains (maybe). And this variable just fix the edge cases for one of our supported libraries (I didn't find which one). In theory, this variable is not needed for compatibility, but it's apple thing.

[henderkes]

Yeah that's a good point, static is the default after all.