-
-
Notifications
You must be signed in to change notification settings - Fork 345
bunch of fixes/changes to make packages build #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Use it externally in v2: // a.php
if (preg_match('/after-library\[(.*)\]-build/', patch_point(), $match)) {
$lib_name = $match[1];
FileSystem::removeDir(SOURCE_PATH . '/' . $lib_name);
}
|
|
That's not working FYI. |
|
I'm silly. Forgot <?php... |
0eda08d to
9e051c8
Compare
|
And I need another vacation. The composer update before push failed because it failed to remove go package stuff in pkgroot. The bugs actually seem fixed. |
|
Everything builds now, except for the macos intel failure, I guess. |
|
Looks like it's a JIT bug on x86_64 mAC05. |
|
Upstream issue here: php/php-src#20767 . Looks like we will need to exclude clang version manually here or use homebrew llvm instead. |
|
Swoole is broken on 8.5 until 6.2 release. Nothing we can realistically do there except manually using custom source option for download. Keeping this PR frozen but open until Swoole releases 6.2. We don't need to add a patch for a dev version, I just need it to build swoole extension for packages.
That will be fixed soon, we don't need to patch for it. |
ce7829f to
64f7a35
Compare
What does this PR do?