Skip to content

Conversation

@henderkes
Copy link
Collaborator

@henderkes henderkes commented Dec 18, 2025

What does this PR do?

  • fix removal of directories with symlinks to directories
  • add mysqlnd_parsec and mysqlnd_ed25519, closes mysqlnd_parsec #1000
  • remove grpc library from grpc ext dependencies
  • temporary swoole patch (remove when 6.2.0 releases!)
  • don't build addons explicitly
  • look for pkgconfig files in all PKG_CONFIG_PATHs so we don't build stuff when a system lib exists and we explicitly want to link against it
  • download --update functionality, can download multiple php versions at once

@crazywhalecc
Copy link
Owner

Use it externally in v2: bin/spc build --build-cli bcmath -P a.php

// a.php
if (preg_match('/after-library\[(.*)\]-build/', patch_point(), $match)) {
    $lib_name = $match[1];
    FileSystem::removeDir(SOURCE_PATH . '/' . $lib_name);
}

v3 will mark this as deprecated, using #BeforeStage and #AfterStage attribute instead. But removal will be performed in v4 (will be a long time)

@henderkes
Copy link
Collaborator Author

That's not working FYI.

@henderkes
Copy link
Collaborator Author

I'm silly. Forgot <?php...

@henderkes
Copy link
Collaborator Author

henderkes commented Dec 19, 2025

Swoole fails with 8.5.1 despite the patch.

Libwebp fails on alma 8 despite the check succeeding...

And I need another vacation. The composer update before push failed because it failed to remove go package stuff in pkgroot. The bugs actually seem fixed.

@henderkes
Copy link
Collaborator Author

Everything builds now, except for the macos intel failure, I guess.

@crazywhalecc
Copy link
Owner

Looks like it's a JIT bug on x86_64 mAC05.

@crazywhalecc
Copy link
Owner

crazywhalecc commented Dec 26, 2025

Upstream issue here: php/php-src#20767 . Looks like we will need to exclude clang version manually here or use homebrew llvm instead.

@henderkes
Copy link
Collaborator Author

henderkes commented Dec 27, 2025

Swoole is broken on 8.5 until 6.2 release. Nothing we can realistically do there except manually using custom source option for download.

Keeping this PR frozen but open until Swoole releases 6.2. We don't need to add a patch for a dev version, I just need it to build swoole extension for packages.

Upstream issue here: php/php-src#20767 .

That will be fixed soon, we don't need to patch for it.

@crazywhalecc crazywhalecc added the mixed PR This PR contains multiple updates label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mixed PR This PR contains multiple updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mysqlnd_parsec

3 participants