Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Dec 23, 2025

About

Stop including rate-limited resources.

References

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

Documentation images updated to use local logo assets across multiple integration and BI pages; Sphinx linkcheck_ignore in docs/conf.py gained r"https://tldp.org/". No functional code changes.

Changes

Cohort / File(s) Summary
Integration docs — logo assets
docs/integrate/aws-lambda/index.md, docs/integrate/dbeaver/index.md, docs/integrate/dynamodb/index.md, docs/integrate/influxdb/index.md, docs/integrate/mongodb/index.md, docs/integrate/n8n/index.md, docs/integrate/node-red/index.md, docs/integrate/oracle/index.md, docs/integrate/powerbi/index.md, docs/integrate/scikit-learn/index.md, docs/integrate/tableau/index.md, docs/integrate/terraform/index.md, docs/integrate/trino/index.md, docs/integrate/risingwave/index.md
Replaced external Wikimedia/Wikipedia logo URLs with local asset paths (e.g., /_assets/icon/...). Image attributes (height, loading, links/anchors) preserved. No other content changes.
BI topic page
docs/topic/bi/index.md
Power BI and Tableau header/logo references switched from external URLs to local assets; attributes preserved.
Sphinx config
docs/conf.py
Appended r"https://tldp.org/" to linkcheck_ignore. No other config changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

maintenance

Suggested reviewers

  • bmunkholm
  • kneth
  • surister

Poem

🐰 Logos hopped from web to tree,

Nestled safe in assets, fancy-free.
No code to scurry, no tests to chase,
Just tidy paths in their new place. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main objective: replacing external Wikipedia logo URLs with local assets to avoid rate limiting across multiple documentation files.
Description check ✅ Passed The description is concise but directly related to the changeset, explaining the purpose of stopping rate-limited resources by bundling logo assets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch less-wikipedia

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 595bb39 and e6faf96.

⛔ Files ignored due to path filters (1)
  • docs/_assets/icon/risingwave-logo.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • docs/integrate/risingwave/index.md
✅ Files skipped from review due to trivial changes (1)
  • docs/integrate/risingwave/index.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl marked this pull request as ready for review December 23, 2025 23:32
@amotl amotl linked an issue Dec 23, 2025 that may be closed by this pull request
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/conf.py (1)

97-98: LGTM! Consider optional cleanup of redundant entry.

The addition of the broader tldp.org ignore pattern is appropriate for handling certificate issues across the domain.

Since this pattern now matches all tldp.org URLs, the specific entry on line 35 (r"https://tldp.org/LDP/Linux-Filesystem-Hierarchy/html/index.html") has become redundant and could be removed.

🔎 Optional cleanup to remove redundant entry
    # Expired certificate.
-   r"https://tldp.org/LDP/Linux-Filesystem-Hierarchy/html/index.html",
    # 403 Client Error: Forbidden for url
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1987f1 and 595bb39.

📒 Files selected for processing (1)
  • docs/conf.py
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: amotl
Repo: crate/cratedb-guide PR: 395
File: docs/install/cloud/azure/terraform.md:108-127
Timestamp: 2025-10-10T17:58:26.545Z
Learning: In the crate/cratedb-guide repository, during documentation format conversions (e.g., from reStructuredText to MyST/Markdown), markdownlint warnings such as MD053 (unused reference-style links) should be ignored and not flagged as issues.
Learnt from: amotl
Repo: crate/cratedb-guide PR: 241
File: docs/integrate/grafana/index.md:37-46
Timestamp: 2025-08-10T17:59:43.508Z
Learning: When verifying cross-references in Sphinx-based documentation, search for both Markdown references (e.g., `(reference-name)=`) and reStructuredText labels (e.g., `.. _reference-name:`) across both .md and .rst files, as Sphinx supports cross-referencing between different markup formats.
Learnt from: amotl
Repo: crate/cratedb-guide PR: 241
File: docs/integrate/grafana/index.md:37-46
Timestamp: 2025-08-10T17:59:43.508Z
Learning: When verifying cross-references in Sphinx-based documentation, search for both Markdown references (e.g., `(reference-name)=`) and reStructuredText labels (e.g., `.. _reference-name:`) across both .md and .rst files, as Sphinx supports cross-referencing between different markup formats.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build docs

@amotl amotl merged commit f8fb37f into main Dec 23, 2025
3 checks passed
@amotl amotl deleted the less-wikipedia branch December 23, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants