-
Notifications
You must be signed in to change notification settings - Fork 1
Chore: Include logo assets from Wikipedia to avoid rate limiting #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation images updated to use local logo assets across multiple integration and BI pages; Sphinx Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/conf.py (1)
97-98: LGTM! Consider optional cleanup of redundant entry.The addition of the broader
tldp.orgignore pattern is appropriate for handling certificate issues across the domain.Since this pattern now matches all
tldp.orgURLs, the specific entry on line 35 (r"https://tldp.org/LDP/Linux-Filesystem-Hierarchy/html/index.html") has become redundant and could be removed.🔎 Optional cleanup to remove redundant entry
# Expired certificate. - r"https://tldp.org/LDP/Linux-Filesystem-Hierarchy/html/index.html", # 403 Client Error: Forbidden for url
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/conf.py
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: amotl
Repo: crate/cratedb-guide PR: 395
File: docs/install/cloud/azure/terraform.md:108-127
Timestamp: 2025-10-10T17:58:26.545Z
Learning: In the crate/cratedb-guide repository, during documentation format conversions (e.g., from reStructuredText to MyST/Markdown), markdownlint warnings such as MD053 (unused reference-style links) should be ignored and not flagged as issues.
Learnt from: amotl
Repo: crate/cratedb-guide PR: 241
File: docs/integrate/grafana/index.md:37-46
Timestamp: 2025-08-10T17:59:43.508Z
Learning: When verifying cross-references in Sphinx-based documentation, search for both Markdown references (e.g., `(reference-name)=`) and reStructuredText labels (e.g., `.. _reference-name:`) across both .md and .rst files, as Sphinx supports cross-referencing between different markup formats.
Learnt from: amotl
Repo: crate/cratedb-guide PR: 241
File: docs/integrate/grafana/index.md:37-46
Timestamp: 2025-08-10T17:59:43.508Z
Learning: When verifying cross-references in Sphinx-based documentation, search for both Markdown references (e.g., `(reference-name)=`) and reStructuredText labels (e.g., `.. _reference-name:`) across both .md and .rst files, as Sphinx supports cross-referencing between different markup formats.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build docs
About
Stop including rate-limited resources.
References