-
Notifications
You must be signed in to change notification settings - Fork 1
Driver: Add page about Scala #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new Scala JDBC guide and driver card to the Connect drivers index, and extracts Java JDBC driver option text into a new include file referenced from the Java driver page. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Reader
participant Index as "docs/connect/index.md"
participant ScalaPage as "docs/connect/scala/index.md"
participant JavaIndex as "docs/connect/java/index.md"
participant DriverOptions as "docs/connect/java/_driver_options.md"
Reader->>Index: open Drivers page
Note over Index: New Scala card added\nand toctree entry
Index->>ScalaPage: navigate to Scala guide
Reader->>ScalaPage: view build.sbt / example.scala / Cloud notes
Reader->>JavaIndex: open Java driver page
JavaIndex->>DriverOptions: include driver-options content
Reader->>DriverOptions: read JDBC driver guidance
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fa8932a to
c979f69
Compare
54cc58a to
d0cd537
Compare
f3870e7 to
1d13e84
Compare
docs/connect/scala/index.md
Outdated
| } | ||
| ``` | ||
|
|
||
| :::{rubric} CrateDB Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same comment here as in the Erlang PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generalized in the same way with 32a032b, thanks.
About
What the title says.
Preview
https://cratedb-guide--412.org.readthedocs.build/connect/scala/