Migrate to GitHub Actions and add test infrastructure with Catch2#96
Open
nhthn wants to merge 7 commits intocraigsapp:masterfrom
Open
Migrate to GitHub Actions and add test infrastructure with Catch2#96nhthn wants to merge 7 commits intocraigsapp:masterfrom
nhthn wants to merge 7 commits intocraigsapp:masterfrom
Conversation
rettinghaus
suggested changes
Jan 26, 2025
Contributor
rettinghaus
left a comment
rettinghaus
left a comment
There was a problem hiding this comment.
Looks preety good to me. Please update to latest major version of the action.
Also you should consider using a matrix strategy, at least for the linux and macOS jobs.
| linux: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
Contributor
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v4 |
| windows: | ||
| runs-on: windows-2019 | ||
| steps: | ||
| - uses: actions/checkout@v2 |
Contributor
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v4 |
| macos: | ||
| runs-on: macos-11 | ||
| steps: | ||
| - uses: actions/checkout@v2 |
Contributor
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Craig! Small world, we've actually met before (Point Lobos trip with Jeff years ago).
I have been using midifile in a singing synthesizer project I'm working on, and it's fantastic. However, there is some bitrot happening in this repo with regards to CMake versions and Travis CI dropping their free tier. I also thought it would be cool to start on integration and unit test coverage.
This PR makes the following changes: